Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pk and vk should also be tagged with ezkl version #866

Open
alexander-camuto opened this issue Nov 7, 2024 · 0 comments
Open

pk and vk should also be tagged with ezkl version #866

alexander-camuto opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alexander-camuto
Copy link
Collaborator

alexander-camuto commented Nov 7, 2024 •
edited
Loading

Right now we inherit the ProvingKey and VerifyingKey structs from our halo2 fork. We should wrap these structs into a meta struct, like:

VersionedProvingKey {
   pk: ProvingKey,
   version: String
}

And add the version to the structs as such
@alexander-camuto alexander-camuto added the enhancement New feature or request label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexander-camuto