Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room access restrictions #28

Open
2 of 3 tasks
zorchenhimer opened this issue Mar 14, 2019 · 1 comment
Open
2 of 3 tasks

Room access restrictions #28

zorchenhimer opened this issue Mar 14, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request front-end Anything HTML/CSS/JS

Comments

@zorchenhimer
Copy link
Owner

zorchenhimer commented Mar 14, 2019

There should be three levels of access to room access:

  • Public
  • Pin/Password
  • Request and grant

Rabbit had the first and third, but the pin/password option would be a useful middle ground between the two. Default access level should be configurable in the settings file and modifiable by an admin via a command in chat (possibly mods too?). Changing the access level in an active room should not kick any users currently connected. Full definitions for each access type are as follows:

Public

Allow access to anybody with the main URL. Video is loaded on page load, and is allowed to chat when a username is entered.

Pin/Password

Landing page is a simple pin or password entry form (with a username to avoid another input step for chat). Video and chat are loaded after a correct pin or password is entered. The pin or password will be global for the room and configurable by both the settings file and a command.

Maybe add the possibility of appending the pin to the URL as a GET variable (eg, ?pin=12345). Following the link will bring up the same landing page but with the pin pre-filled, leaving only a name to be entered.

Request/grant

Landing page is a simple name entry form and a button to request access to the room. Once submitted, mods and admins in the room will be notified and given the option to allow or deny access to the user requesting access, either by a pop-up of some sort or a command (command route might be a bit unwieldy for the mod/admin however).


I would personally like to use the pin/password method, but I do know some other streamers that I believe would prefer the Request/grant method instead.

@zorchenhimer zorchenhimer added enhancement New feature or request front-end Anything HTML/CSS/JS labels Mar 14, 2019
@zorchenhimer zorchenhimer self-assigned this Mar 21, 2019
zorchenhimer added a commit that referenced this issue Apr 4, 2019
Merge in the room access restrictions changes into master.  Currently,
only the PIN/Password method is implemented, and it's not all that
secure.  Some more work needs to be done in planning before really
moving forward, but this should be fine for now.

Issue #28 should not be considered finished with this merge.
@zorchenhimer
Copy link
Owner Author

Appending the PIN to the URL has been added with e051cad. All that's left for this issue is the request/grant workflow. I'm not entirely sure if I still want to do that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end Anything HTML/CSS/JS
Projects
None yet
Development

No branches or pull requests

1 participant