-
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
@satanb4 The status does not refer to the tab but to the application's connection to the server. 🤔 |
Then why have we been focusing on closing the tab's connection to the server? Also, from the user point of view of the tab session being closed, it makes more sense. Please go through issue #66 where I have discussed this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the plumbing to add Firefox to the Travis CI pipeline? It should be trivial.
Commit still buggy, when ready for review, I will request |
Okay, @satanb4. I'll be waiting for you! 😉 |
Can be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satanb4 Thanks for that. But can you let the status refer to the application's connection to the server again, please? We can talk about it after, but for now, we don't want to show the tab status. Now, if the tab was disconnected, it is closed, and vice-versa. So, the "tab status" it's more redundancy, and we lost a functionality: show the application status.
I'll get that done |
I have fixed the tab connection. As well as performance improvement. Review requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Need the coveralls repo token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ, @satanb4! 🤓
Description
This is a PR for fixing issues in #66 More changes will be pushed incrementally
Fixes issue #66
Motivation and Context
Tab closing and session confusion
#66 Session closing and log generation
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: