-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document the config file #194
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 suggestion.
Files not reviewed (1)
- crates/cdk/src/main.rs: Evaluated as low risk
Comments skipped due to low confidence (1)
config/default.go:3
- The comment contains spelling errors. 'This' should be 'These' and 'doesnt' should be 'doesn't'.
// This values doesnt have a default value because depend on the environment / deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- crates/cdk/versions.json: Language not supported
- cmd/config.go: Evaluated as low risk
- crates/cdk-config/src/aggregator.rs: Evaluated as low risk
Remove the panda as it's not file friendly.
Quality Gate passedIssues Measures |
Add documentation to config file
config.go
when existing