This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Stop use interface and more accurate naming #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitu5ami
force-pushed
the
marcin/cleanup
branch
3 times, most recently
from
8606a8d to
b809cd1
Compare
There's no reason for this code to use interface for a health check probes. What's more, returning an interface is wrong. We should pass interface, do not return it.
eitu5ami
force-pushed
the
marcin/cleanup
branch
from
b809cd1 to
10773a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason for this code to use interface for a health check probes. What's more, returning an interface is wrong. We should pass interface, do not return it.