Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full image specification of dockerized integrated-devnet #406

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Aug 31, 2023

Usage related changes

Development related changes

N/A

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC changed the title Integrate devnet-rs Add support for full image specification of dockerized integrated-devnet Sep 6, 2023
@FabijanC FabijanC changed the title Add support for full image specification of dockerized integrated-devnet Support for full image specification of dockerized integrated-devnet Sep 6, 2023
@FabijanC FabijanC marked this pull request as ready for review September 6, 2023 10:48
@FabijanC FabijanC requested a review from penovicp September 6, 2023 11:31
@FabijanC FabijanC changed the title Support for full image specification of dockerized integrated-devnet Support full image specification of dockerized integrated-devnet Sep 6, 2023
Copy link
Contributor

@penovicp penovicp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue in the docs, lgtm.

www/docs/intro.md Outdated Show resolved Hide resolved
@FabijanC FabijanC merged commit 89e7482 into master Sep 6, 2023
@FabijanC FabijanC deleted the integrated-devnet-rs branch September 6, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants