Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix author alert message #3822

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix author alert message #3822

merged 1 commit into from
May 15, 2024

Conversation

beechnut
Copy link
Contributor

@beechnut beechnut commented Apr 12, 2024

There were two conflicting files for qituwra-anderson. The most recent (plaintext) had published=true, the older one (Markdown) had published=false.

Every time the site gets built, there's a little warning in the logs about this conflict.

Pull request summary

This PR deletes the plaintext file and sets the markdown file to published=true (the most recent value).

Reminder - please do the following before assigning reviewer

  • Update readme
  • For frontend changes, ensure design review
  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introdcued

There were two conflicting files for qituwra-anderson. The most recent (plaintext) had published=true, the older one (Markdown) had published=false.

This commit deletes the plaintext file and sets the markdown file to published=true.
@beechnut beechnut requested a review from a team as a code owner April 12, 2024 13:35
@beechnut beechnut requested a review from MelissaBraxton April 12, 2024 13:37
Copy link
Member

@neilmb neilmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for noticing.

@beechnut beechnut mentioned this pull request Apr 12, 2024
4 tasks
@cantsin
Copy link
Member

cantsin commented May 15, 2024

Looks like this is still an issue -- merging.

@cantsin cantsin merged commit 9ef9192 into main May 15, 2024
5 checks passed
@cantsin cantsin deleted the beechnut/fix-author-alert branch May 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants