-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some image tags #3863
Migrate some image tags #3863
Conversation
content/posts/2014-09-04-a-new-look-at-the-freedom-of-information-act.md
Show resolved
Hide resolved
_sass/_components/utilities.scss
Outdated
@@ -69,3 +69,54 @@ | |||
text-indent: units(-2); | |||
} | |||
|
|||
.height-67px { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable temporary solution, but it's not a pattern I'd want us to establish for future blog posts with images. Let's see if we can iterate on this before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a speculative fix for this in 3796cb7: I say "speculative", because I think the post
layout isn't currently getting applied to this particular blog post. (Edit: might be related to #3849.) Let me know how you'd like me to proceed: I did a quick in-inspector test to make sure the layout works, but this will likely need visual QA/refinement once the layout's fixed. (Happy to revert the style edit, too!)
...continuously-how-we-iterated-on-our-bot-to-promote-more-inclusive-and-thoughtful-language.md
Outdated
Show resolved
Hide resolved
04ea4cf
to
8297df3
Compare
Heartburn about the width-### classes aside, this looks good to merge |
I knew I liked you, @beechnut Thank you so much for the review, and for all the help getting this over the line! |
Pull request summary
Partially does #3862.
Reminder - please do the following before assigning reviewer
And make sure that automated checks are ok