Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Jekyll styles with 11ty-friendly markdown #3974

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

sam-couch-18f
Copy link
Member

Pull request summary

Replaces Jekyll inline styles with 11ty-friendly HTML classes, using markdown-it (which is already included in the project).

Related to TLC ticket #3971

@sam-couch-18f sam-couch-18f requested a review from beechnut July 11, 2024 16:17
@beechnut
Copy link
Contributor

@sam-couch-18f OMG was the fix here just removing the leading colon? That was it?!

@beechnut beechnut force-pushed the replace-jekyll-styles branch from a679fd0 to 58181b8 Compare July 11, 2024 18:51
@sam-couch-18f
Copy link
Member Author

@beechnut can you believe it! All it took was removing the colons, adding spaces between the class names, and some slight tweaks to line breaks to get it to work. Stumbled on this page during some Googling and gave it a shot.

@sam-couch-18f sam-couch-18f marked this pull request as ready for review July 11, 2024 19:04
@sam-couch-18f sam-couch-18f requested a review from a team as a code owner July 11, 2024 19:04
@sam-couch-18f sam-couch-18f merged commit 646efb4 into replatform-main Jul 11, 2024
5 checks passed
@sam-couch-18f sam-couch-18f deleted the replace-jekyll-styles branch July 11, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants