Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrity check #3710

Closed
wants to merge 12 commits into from
Closed

integrity check #3710

wants to merge 12 commits into from

Conversation

mgwalker
Copy link
Member

Changes proposed in this pull request:

  • Adds a regular site integrity check by comparing the hash of files from the most recent build with the hash of the corresponding files on the web.

security considerations

[Note the any security considerations here, or make note of why there are none]

@mgwalker mgwalker requested a review from a team as a code owner September 16, 2023 18:53
Copy link
Member

@JJediny JJediny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integrity checks look good to merge @mgwalker

@mgwalker
Copy link
Member Author

Oops, this reminds me I need to actually finish this. 😂

@mgwalker mgwalker force-pushed the mgwalker/integrity-checking branch from deeb996 to 906ac5b Compare October 13, 2023 14:19
@mgwalker
Copy link
Member Author

Actually just gonna close this. We don't have enough control over cloud.gov Pages and can't get enough information back from it to do this kind of integrity checking. This work was spurred by an idea at 18F IRL in September (hat tip to @rahearn), but the practical value in this situation is pretty low and not worth figuring out all the weirdness.

@mgwalker mgwalker closed this Oct 13, 2023
@mgwalker mgwalker deleted the mgwalker/integrity-checking branch October 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants