Lg 15251 avoid linking email address #11717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsmaster5
approved these changes
Jan 9, 2025
aduth
requested changes
Jan 10, 2025
| @@ -55,6 +55,16 @@ def last_email | |||
| end | |||
| end | |||
|
|
|||
| def selected_email_id | |||
| if current_sp.present? && | |||
| current_sp.attribute_bundle&.include?('all_email') && | |||
There was a problem hiding this comment.
There is no attribute all_email. This should be all_emails.
| @@ -57,6 +57,11 @@ def friendly_name | |||
| sp_metadata[:friendly_name] | |||
| end | |||
|
|
|||
| def all_email_and_single_email_requested? | |||
There was a problem hiding this comment.
I don't think this is the behavior we're expecting. A partner would only request either email or all_emails in most cases. We only want to link the email if they requested a singular email, since this is when we show the option for the user to choose which email should be shared.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15251
🛠 Summary of changes
This allows Service providers with both 'all_emails' and 'email' attribute bundle to receive the last email sued for sign in instead of the email selected by the user.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
-->