Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-15379 removes post office closure alerts from barcode page and email #11733

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LG-15379 removes post office closure alerts from barcode page and email #11733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8aa264
LG-15379 removes post office closure alerts from barcode page and email
jennyverdeyen Jan 10, 2025
a1aefde
remove feature flag after all
jennyverdeyen Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/controllers/idv/in_person/ready_to_verify_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ class ReadyToVerifyController < ApplicationController

def show
@is_enhanced_ipp = resolved_authn_context_result.enhanced_ipp?
@show_closed_post_office_banner =
IdentityConfig.store.in_person_proofing_post_office_closed_alert_enabled
analytics.idv_in_person_ready_to_verify_visit(**opt_in_analytics_properties)
@presenter = ReadyToVerifyPresenter.new(
enrollment: enrollment,
Expand Down
8 changes: 0 additions & 8 deletions app/views/idv/in_person/ready_to_verify/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,6 @@
</section>
<% end %>

<%# Alert %>
<% if @show_closed_post_office_banner %>
<%= render AlertComponent.new(type: :warning, class: 'margin-y-4', text_tag: :div) do %>
<p class="margin-bottom-1 margin-top-0 h3"><strong><%= t('in_person_proofing.post_office_closed.heading') %></strong></p>
<p><%= t('in_person_proofing.post_office_closed.body') %></p>
<% end %>
<% end %>

<% if !@is_enhanced_ipp %>
<h3><%= t('in_person_proofing.body.location.change_location_heading') %></h3>
<p class="margin-bottom-4">
Expand Down
15 changes: 0 additions & 15 deletions app/views/user_mailer/shared/_in_person_ready_to_verify.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,21 +275,6 @@
</div>
<% end %>

<%# alert %>
<% if @show_closed_post_office_banner %>
<table class="usa-alert usa-alert--warning margin-y-4">
<tr>
<td style="width:16px;">
<%= image_tag('email/warning.png', width: 16, height: 16, alt: '', style: 'margin-top: 4px;') %>
</td>
<td>
<p class="margin-bottom-1"><strong><%= t('in_person_proofing.post_office_closed.heading') %></strong></p>
<p class="margin-bottom-0"><%= t('in_person_proofing.post_office_closed.body') %></p>
</td>
</tr>
</table>
<% end %>

<% if !@is_enhanced_ipp %>
<h3><%= t('in_person_proofing.body.location.change_location_heading') %></h3>
<p class="margin-bottom-4">
Expand Down
1 change: 0 additions & 1 deletion config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ in_person_outage_message_enabled: false
in_person_proofing_enabled: false
in_person_proofing_enforce_tmx: false
in_person_proofing_opt_in_enabled: false
in_person_proofing_post_office_closed_alert_enabled: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @eileen-nava we decided to remove the flag while we're cleaning up the other temporary code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another line in this file that needs to be deleted

in_person_results_delay_in_hours: 1
in_person_send_proofing_notifications_enabled: false
in_person_stop_expiring_enrollments: false
Expand Down
5 changes: 0 additions & 5 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,11 +1327,6 @@ in_person_proofing.headings.state_id_milestone_2: Enter the information on your
in_person_proofing.headings.switch_back: Switch back to your computer to prepare to verify your identity in person
in_person_proofing.headings.update_address: Update your current address
in_person_proofing.headings.update_state_id: Update the information on your ID
in_person_proofing.post_office_closed.body: Post Office locations will resume regular hours on Friday, January 10, 2025.
in_person_proofing.post_office_closed.email.body_html: <strong>You will not be able to visit a Post Office on Thursday, January 9, 2025 to finish verifying your identity.</strong> Post Office locations will resume regular hours on Friday, January 10, 2025.
in_person_proofing.post_office_closed.email.heading: All Post Offices will be closed on January 9, 2025 to honor former President Jimmy Carter
in_person_proofing.post_office_closed.email.subject: All Post Offices will be closed on Thursday, January 9, 2025
in_person_proofing.post_office_closed.heading: All Post Offices will be closed on Thursday, January 9, 2025 to honor former President Jimmy Carter.
in_person_proofing.process.barcode.caption_label: Enrollment code
in_person_proofing.process.barcode.heading: Show your %{app_name} barcode
in_person_proofing.process.barcode.info: The retail associate needs to scan your barcode at the top of this page. You can print this page or show it on your mobile device.
Expand Down
5 changes: 0 additions & 5 deletions config/locales/es.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,11 +1338,6 @@ in_person_proofing.headings.state_id_milestone_2: Ingrese la información de su
in_person_proofing.headings.switch_back: Vuelva a su computadora para preparar la verificación de su identidad en persona
in_person_proofing.headings.update_address: Actualice su dirección actual
in_person_proofing.headings.update_state_id: Actualice la información de su identificación
in_person_proofing.post_office_closed.body: Las oficinas de correos reanudarán su horario habitual el viernes 10 de enero de 2025.
in_person_proofing.post_office_closed.email.body_html: <strong>No podrás visitar una Oficina de Correos el jueves 9 de enero de 2025 para terminar de verificar tu identidad.</strong> Las oficinas de correos reanudarán su horario habitual el viernes 10 de enero de 2025.
in_person_proofing.post_office_closed.email.heading: Todas las oficinas de correos estarán cerradas el 9 de enero de 2025 en honor al expresidente Jimmy Carter
in_person_proofing.post_office_closed.email.subject: Todas las oficinas de correos estarán cerradas el jueves 9 de enero de 2025
in_person_proofing.post_office_closed.heading: Todas las oficinas de correos estarán cerradas el jueves 9 de enero de 2025 en honor al ex presidente Jimmy Carter.
in_person_proofing.process.barcode.caption_label: Código de registro
in_person_proofing.process.barcode.heading: Muestre su código de barras de %{app_name}
in_person_proofing.process.barcode.info: El empleado debe escanear el código de barras que aparece en la parte superior de esta página. Puede imprimir esta página o mostrarla en su dispositivo móvil.
Expand Down
5 changes: 0 additions & 5 deletions config/locales/fr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1327,11 +1327,6 @@ in_person_proofing.headings.state_id_milestone_2: Saisissez les informations fig
in_person_proofing.headings.switch_back: Revenez à votre ordinateur pour vous préparer à confirmer votre identité en personne
in_person_proofing.headings.update_address: Mettez à jour votre adresse actuelle
in_person_proofing.headings.update_state_id: Mettez à jour les informations figurant sur votre document d’identité
in_person_proofing.post_office_closed.body: Les bureaux de poste reprendront leurs horaires habituels le vendredi 10 janvier 2025.
in_person_proofing.post_office_closed.email.body_html: <strong>Vous ne pourrez pas vous rendre dans un bureau de Poste le jeudi 9 janvier 2025 pour terminer la vérification de votre identité.</strong> Les bureaux de poste reprendront leurs horaires habituels le vendredi 10 janvier 2025
in_person_proofing.post_office_closed.email.heading: Tous les bureaux de poste seront fermés le 9 janvier 2025 en l’honneur de l’ancien président Jimmy Carter
in_person_proofing.post_office_closed.email.subject: Tous les bureaux de poste seront fermés le jeudi 9 janvier 2025
in_person_proofing.post_office_closed.heading: Tous les bureaux de poste seront fermés le jeudi 9 janvier 2025 en l’honneur de l’ancien président Jimmy Carter.
in_person_proofing.process.barcode.caption_label: Code d’inscription
in_person_proofing.process.barcode.heading: Montrez votre code-barres %{app_name}
in_person_proofing.process.barcode.info: Le préposé doit scanner votre code-barres en haut de cette page. Vous pouvez imprimer cette page ou la montrer sur votre appareil mobile.
Expand Down
5 changes: 0 additions & 5 deletions config/locales/zh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,11 +1340,6 @@ in_person_proofing.headings.state_id_milestone_2: 输入你州政府颁发身份
in_person_proofing.headings.switch_back: 切换回你的电脑，来准备亲身去验证身份。
in_person_proofing.headings.update_address: 更新你当前地址
in_person_proofing.headings.update_state_id: 更新你身份证件上的信息
in_person_proofing.post_office_closed.body: 邮局地点将于 2025 年 1 月 10 日星期五恢复正常工作时间。
in_person_proofing.post_office_closed.email.body_html: <strong>您将无法在 2025 年 1 月 9 日星期四前往邮局完成身份验证。</strong> 邮局地点将于 2025 年 1 月 10 日星期五恢复正常工作时间
in_person_proofing.post_office_closed.email.heading: 所有邮局将于 2025 年 1 月 9 日关闭，以纪念前总统吉米·卡特
in_person_proofing.post_office_closed.email.subject: 所有邮局将于 2025 年 1 月 9 日星期四关闭
in_person_proofing.post_office_closed.heading: 所有邮局将于 2025 年 1 月 9 日关闭，以纪念前总统吉米·卡特。
in_person_proofing.process.barcode.caption_label: 注册代码
in_person_proofing.process.barcode.heading: 出示你的 %{app_name} 条形码
in_person_proofing.process.barcode.info: 邮局工作人员需要扫描该页顶部的条形码你可以把该页打印出来，或在你的移动设备上显示。
Expand Down
44 changes: 0 additions & 44 deletions spec/mailers/user_mailer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,50 +934,6 @@ def expect_email_body_to_have_help_and_contact_links
end
end

context 'post office closed alert' do
context 'when the post office closed alert flag is disabled' do
before do
allow(IdentityConfig.store)
.to receive(:in_person_proofing_post_office_closed_alert_enabled)
.and_return(false)
end

it 'does not render the post office closed alert' do
aggregate_failures do
[
t('in_person_proofing.post_office_closed.heading'),
t('in_person_proofing.post_office_closed.body'),
].each do |copy|
Array(copy).each do |part|
expect(mail.html_part.body).to_not have_content(part)
end
end
end
end
end

context 'when the post office closed alert flag is enabled' do
before do
allow(IdentityConfig.store)
.to receive(:in_person_proofing_post_office_closed_alert_enabled)
.and_return(true)
end

it 'renders the post office closed alert' do
aggregate_failures do
[
t('in_person_proofing.post_office_closed.heading'),
t('in_person_proofing.post_office_closed.body'),
].each do |copy|
Array(copy).each do |part|
expect(mail.html_part.body).to have_content(part)
end
end
end
end
end
end

context 'Need to change location section' do
context 'when Enhanced IPP is not enabled' do
let(:is_enhanced_ipp) { false }
Expand Down
44 changes: 0 additions & 44 deletions spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,50 +176,6 @@
end
end

context 'post office warning' do
context 'when the show closed post office banner is disabled' do
before do
@show_closed_post_office_banner = false
end

it 'does not render the post office closed alert' do
render

aggregate_failures do
[
t('in_person_proofing.post_office_closed.heading'),
t('in_person_proofing.post_office_closed.body'),
].each do |copy|
Array(copy).each do |part|
expect(rendered).to_not have_content(part)
end
end
end
end
end

context 'when the show closed post office banner is enabled' do
before do
@show_closed_post_office_banner = true
end

it 'renders the post office closed alert' do
render

aggregate_failures do
[
t('in_person_proofing.post_office_closed.heading'),
t('in_person_proofing.post_office_closed.body'),
].each do |copy|
Array(copy).each do |part|
expect(rendered).to have_content(part)
end
end
end
end
end
end

context 'what to expect section' do
context 'when Enhanced IPP is not enabled' do
let(:is_enhanced_ipp) { false }
Expand Down