Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for PIV/CAC mismatch #11735

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

vrajmohan
Copy link
Member

changelog: User-Facing Improvements, Translations, Update translations for PIV/CAC mismatch

🎫 Ticket

Link to the relevant ticket:
DOS CHANGES LQA (Sprint 325) - Improved messaging for PIV/CAC mismatch

👀 Screenshots

I have attached screenshots to the JIRA ticket.

titles.piv_cac_login.add: 添加您的政府雇员ID
titles.piv_cac_login.add: 添加你的政府雇员ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback document says to replace "ID" with "身份证件", but ID remains here.

@vrajmohan
Copy link
Member Author

Sorry I forgot to add that there are 3 outstanding issues that are discussed in open comments in the Google document:

  1. ID in Chinese
  2. NIP -> PIN in French
  3. There are other places where the string "个人识别号码(PIN)" occurs, e.g. " 那个 PIV/CAC 没起作用。确保 PIV/CAC 是这个账户的。如果的确是,那你的PIV/CAC、个人识别号码(PIN)有问题,或者我们这边出
    了问题。再试一次或选择另一个身份证实方法。"

changelog: User-Facing Improvements, Translations, Update translations for PIV/CAC mismatch
@vrajmohan vrajmohan force-pushed the vm-update-translations-for-pivcac-mismatch branch from 4715266 to 892edc9 Compare January 10, 2025 19:03
@vrajmohan vrajmohan requested a review from aduth January 10, 2025 21:57
@vrajmohan vrajmohan merged commit f5c2cf6 into main Jan 14, 2025
2 checks passed
@vrajmohan vrajmohan deleted the vm-update-translations-for-pivcac-mismatch branch January 14, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants