Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Изменяем имя workflow run для release-oci #580

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

v-a-v
Copy link
Contributor

@v-a-v v-a-v commented Jan 15, 2025

Pull Request description

Changelog

  • Some changes (A description of the changes proposed in the pull request.)

Issues

  • ONPREM-1388 (Link to related issue)

Breaking changes

  • If there are breaking changes, they need to be added to the file Breaking-Changes

Check-list. Чек-лист код-ревью

  • Запрос на слияние в develop.
  • Есть описание к PR.
  • Указаны блокирующие изменения. Breaking-Changes
  • Соответствие кода принятому стилю
    • Описание настроек.
    • Именование настроек.
    • Дефолтные значения.
    • Стиль кода.
  • Работоспособность. Разворачивается на своем окружении из ветки PR.
    • Тест API через тесты helmfile-хуков или коллекций Postman.
  • Не осталось мусора от удаления каких-то параметров. Ищется поиском по проекту из ветки PR.
  • Отработка линтера на чарт из ветки PR. Пример: helm lint charts/search-api

@v-a-v v-a-v requested review from a team as code owners January 15, 2025 07:58
@v-a-v v-a-v merged commit d12afbb into develop Jan 15, 2025
4 checks passed
@v-a-v v-a-v deleted the ONPREM-1388-4 branch January 15, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants