Launch viewer in background and discard output #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents paperboy's UI from becoming unresponsive while the external viewer is running. This also makes it possible to have multiple viewer instances running at the same time.
Easier extensibility than with specialised code for each one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the user interface no longer becomes unresponsive when the external viewer is blocking (#26), and the interface is no longer garbled by output from the external viewer (#25).
Previously, paperboy checked the output from a viewer launch attempt to detect if the launch failed (due to errors or because the viewer command wasn't available on the system).
This change sacrifices the error detection; it only checks (separately, beforehand) whether the viewer command exists. This should be sufficient, as any launch problems that would cause an error return code (non-existent file, insufficient permissions, insufficient memory, …) would affect all viewers anyway.