[WIP] feat: support XCocaineHTTPProtoVersion logic #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XCocaineHTTPProtoVersion sets when the reply must be sent Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
noxiouz
force-pushed
the
feat_x_http_proto_version
branch
from
2c0f6e8 to
02e5044
Compare
3Hren
requested changes
Jun 20, 2017
| @@ -28,10 +29,12 @@ use cocaine::protocol::{self, Flatten}; | |||
| use logging::AccessLogger; | |||
| use pool::{Event, EventDispatch, Settings}; | |||
| use route::{Match, Route}; | |||
| use self::CocaineHttpProtoVersion::{Proto10, Proto11}; | |||
|
|
||
| impl FromStr for CocaineHttpProtoVersion { | ||
| type Err = Error; | ||
| fn from_str(s: &str) -> Result<CocaineHttpProtoVersion, Error> { |
| impl FromStr for CocaineHttpProtoVersion { | ||
| type Err = Error; | ||
| fn from_str(s: &str) -> Result<CocaineHttpProtoVersion, Error> { | ||
| Ok(match s { |
There was a problem hiding this comment.
I try to avoid nested braces.
This looks better:
match s {
"1.0" => Ok(Proto10),
"1.1" => Ok(Proto11),
_ => Err(Error::InvalidCocaineHttpProtoVersion),
}| match resp.headers().get::<XCocaineHTTPProtoVersion>() { | ||
| Some(h) => { | ||
| match CocaineHttpProtoVersion::from_str(h) { | ||
| Err(err) => { |
There was a problem hiding this comment.
Something went wrong with indents here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XCocaineHTTPProtoVersion sets when the reply must be sent
It looks like 💩
Related to #12