Merge pull request #770 from 3box/hotfix/address-message-recover-check

Hotfix/address message recover check
3box · Apr 21, 2020 · d14d8e3 · d14d8e3
2 parents b755fb3 + 713ac86
commit d14d8e3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,5 +1,8 @@
 # Release Notes
 
+## v1.18.1 - 2020-04-21
+* fix: address recover signature check
+
 ## v1.18.0 - 2020-04-21
 * feat: opt in support for [3ID Connect Provider](https://github.com/3box/3id-connect)
 * fix: confidential threads support with IdentityWallet

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "3box",
-  "version": "1.18.0",
+  "version": "1.18.1",
   "description": "Interact with user data",
   "main": "lib/3box.js",
   "directories": {

diff --git a/src/utils/index.js b/src/utils/index.js
@@ -59,7 +59,7 @@ module.exports = {
     const res = await callRpc(ethereum, method, params, fromAddress)
 
     if (fromAddress) {
-      const recoveredAddr = verifyMessage(msg, res).toLowerCase()
+      const recoveredAddr = verifyMessage(text, res).toLowerCase()
       if (fromAddress !== recoveredAddr) throw new Error('Provider returned signature from different account than requested')
     }
 
@@ -75,7 +75,7 @@ module.exports = {
     const res = await callRpc(ethereum, method, params, fromAddress)
 
     if (fromAddress) {
-      const recoveredAddr = verifyMessage(msg, res).toLowerCase()
+      const recoveredAddr = verifyMessage(text, res).toLowerCase()
       if (fromAddress !== recoveredAddr) throw new Error('Provider returned signature from different account than requested')
     }