🤖 Merge PR DefinitelyTyped#71519 [gsi] Fix types for renderbutton by …

…@cprecioso
47-studio-org · Dec 28, 2024 · 7dbd23a · 7dbd23a
1 parent bf3d8cb
commit 7dbd23a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/types/gsi/gsi-tests.ts b/types/gsi/gsi-tests.ts
@@ -41,7 +41,7 @@ google.accounts.id.prompt(notification => {
 /**
  * @see https://developers.google.com/identity/gsi/web/reference/js-reference#google.accounts.id.renderButton
  */
-google.accounts.id.renderButton("#parent-element", { type: "standard" });
+google.accounts.id.renderButton(document.getElementById("#parent-element")!, { type: "standard" });
 
 /**
  * @see https://developers.google.com/identity/gsi/web/reference/js-reference#google.accounts.id.disableAutoSelect

diff --git a/types/gsi/index.d.ts b/types/gsi/index.d.ts
@@ -175,7 +175,7 @@ declare namespace google.accounts.id {
      * @param parent The parent element onto which to mount the Sign In With Google button.
      * @param options Button configuration options.
      */
-    function renderButton(parent: string, options: GsiButtonConfiguration): void;
+    function renderButton(parent: HTMLElement, options: GsiButtonConfiguration): void;
 
     /**
      * When the user signs out of your website, you need to call the method google.accounts.id.disableAutoSelect to record the status in cookies. This prevents a UX dead loop.