Skip to content

Commit

Permalink
[Upkeep][XLA-Code-Health] Resolve 4 instances of the following issue:…
Browse files Browse the repository at this point in the history
… Todo (resolved)

PiperOrigin-RevId: 699627340
  • Loading branch information
Varcho authored and tensorflower-gardener committed Nov 24, 2024
1 parent c6d22c1 commit 43a3801
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions third_party/xla/xla/service/gpu/gpu_compiler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,6 @@ absl::Status RunOptimizationPasses(

pipeline.AddPass<DynamicIndexSplitter>();

// TODO(b/64094172): make Call work on GPU instead of inlining.
pipeline.AddPass<CallInliner>();

pipeline.AddPass<StochasticConvertDecomposer>();
Expand Down Expand Up @@ -1509,9 +1508,6 @@ absl::Status GpuCompiler::OptimizeHloPostLayoutAssignment(
// Greedy pattern matching for custom kernel fusions. We run it before
// Triton rewriter or a regular Gemm rewriter to be able to match compatible
// GEMMs before they matched into Triton gemm or a cuBLAS custom call.
//
// TODO(b/361267225): Remove once we have a unified autotuner for Triton and
// custom kernel fusions.
if (debug_options.xla_gpu_enable_custom_fusions()) {
pipeline.AddPass<SimplifyFPConversions>();
pipeline.AddPass<CustomKernelFusionRewriter>(
Expand Down Expand Up @@ -1539,7 +1535,6 @@ absl::Status GpuCompiler::OptimizeHloPostLayoutAssignment(
} else if (cuda_cc != nullptr &&
cuda_cc->major == se::CudaComputeCapability::VOLTA) {
// Greedy pattern matching for custom kernel fusions.
// TODO(b/361267225): Add Custom Kernel Fusions to GEMM Fusion Autotuner.
pipeline.AddPass<SimplifyFPConversions>();
pipeline.AddPass<CustomKernelFusionRewriter>(
&gpu_target_config.device_description);
Expand Down
2 changes: 1 addition & 1 deletion third_party/xla/xla/xla.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,7 @@ message ExecutionOptions {
// Used to seed random-number generators used in this computation. If this is
// 0, we generate a seed ourselves.
//
// TODO(b/32083678): Changing the seed unnecessarily forces a recompilation.
// Changing the seed unnecessarily forces a recompilation.
uint64 seed = 3;

DebugOptions debug_options = 4;
Expand Down

0 comments on commit 43a3801

Please sign in to comment.