Keep event sheet scroll location when switching functions #7279
Conversation
| scrollToPosition(position: number) { | ||
| const currentList = this._list; | ||
| if (currentList) { | ||
| const listWrapper = currentList.wrappedInstance.current; | ||
| listWrapper && listWrapper.scrollToPosition(position); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not actually used. Should I remove it?
There was a problem hiding this comment.
Isn't it used by the EventsSheet when you call scrollToPosition?
There was a problem hiding this comment.
yes, which is not used either.
There was a problem hiding this comment.
Yes let's clean dead functions. Because these things are hard to get right, we might as well avoid making the component public surface more complex than what it should be
| @@ -333,6 +333,7 @@ type EventsTreeProps = {| | |||
| onEventMoved: (previousRowIndex: number, nextRowIndex: number) => void, | |||
| onEndEditingEvent: (event: gdBaseEvent) => void, | |||
| onScroll?: () => void, | |||
| scrollPosition?: number, | |||
There was a problem hiding this comment.
I would call this initialScrollPosition because changing this props won't impact a component already mounted
|
The |
No description provided.