Fix issue with PHPUnit test paths on linux #181
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you @DumbergerL for all the work you've put in with 2.0! It's looking great!
It seems like calling PHPUnit fails (at least on Linux), because phpunit.xml still has the lowercase directory names instead of the ones you've changed in #165. Perhaps it didn't fail on Windows because directories there are often treated case-insensitive (I didn't validate that however). It's a good step to make tests PSR-4 compliant though!
I wondered why PHPUnit didn't fail in CI and saw that for some reason it doesn't throw an error in Github Actions, but it says "No tests executed!". Perhaps PHPUnit could be setup to fail when no tests are executed? https://github.com/5pm-HDH/churchtools-api/actions/runs/6744038583/job/18333071116