Moved group type classes to separate namespace #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stollr Basically, I think it's a great suggestion. However, I'm a bit afraid to merge it because it's a breaking change. I would like to try to keep the project as stable as possible with version 2. There are enough breaking changes in the ChurchTools API, so I want to at least try to cushion this a little with the project here. I would take the change into account when switching to a new major version. |
|
But there was no release since the addition of the group type, so I think this would not be regarded as a BC break. |
DumbergerL
force-pushed
the
group_type_moved
branch
from
e1e727b to
8306200
Compare
|
You are absolutely right. Sorry. I did not realise that this feature had not yet been shipped. Thank you very much! |
|
You're welcome 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to move the group type classes to a separate namespace, because I think it is more consistent to place the group type classes to their own namespace like other models.
What do you think?