Improve error message

AArnott · Dec 30, 2024 · 739bc34 · 739bc34
1 parent 2658a4b
commit 739bc34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Xunit.Combinatorial/CombinatorialClassDataAttribute.cs b/src/Xunit.Combinatorial/CombinatorialClassDataAttribute.cs
@@ -36,7 +36,7 @@ public CombinatorialClassDataAttribute(Type valuesSourceType, params object[]? a
         if (!typeof(IEnumerable<object[]>).IsAssignableFrom(valuesSourceType))
         {
             throw new InvalidOperationException(
-                $"The values source must be assignable to {typeof(IEnumerable<object?[]>)}).");
+                $"The values source {valuesSourceType} must be assignable to {typeof(IEnumerable<object?[]>)}).");
         }
 
         IEnumerable<object[]>? values;

diff --git a/test/Xunit.Combinatorial.Tests/CombinatorialClassDataAttributeTests.cs b/test/Xunit.Combinatorial.Tests/CombinatorialClassDataAttributeTests.cs
@@ -4,7 +4,7 @@
 using System.Collections;
 using Xunit;
 
-public class CombinatorialClassDataAttributeTests
+public class CombinatorialClassDataAttributeTests(ITestOutputHelper logger)
 {
     private static readonly object?[] ExpectedItems =
     {
@@ -24,6 +24,7 @@ public void Ctor_TheoryData_MissingClassDataArguments_Throws()
     {
         Action ctor = () => new CombinatorialClassDataAttribute(typeof(MyTheoryDataValuesSourceWithParameters));
         InvalidOperationException exception = Assert.Throws<InvalidOperationException>(ctor);
+        logger.WriteLine(exception.Message);
         Assert.Equal(
             $"Failed to create an instance of {typeof(MyTheoryDataValuesSourceWithParameters)}. " +
             "Please make sure the type has a public constructor and the arguments match.",