Frida updates and FASAN fixes #2838
Open
+928
−498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mineo333
reviewed
Jan 14, 2025
| @@ -96,6 +96,25 @@ thread_local! { | |||
| static ASAN_IN_HOOK: Cell<bool> = const { Cell::new(false) }; | |||
| } | |||
|
|
|||
| #[inline] | |||
| #[cfg(target_arch = "aarch64")] | |||
| unsafe fn thread_local_initted() -> bool { | |||
There was a problem hiding this comment.
Out of curiosity, what is the purpose of thread_local_initted?
There was a problem hiding this comment.
We use a thread local variable to determine if we are hooked or not, but sometimes a new thread spawns and we need to know if we are hooked or not BEFORE TLS has been set up. E.g. in the malloc call made by the TLS setup itself.
So we just ignore any calls before TLS is initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.