Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable c4/en, c4/multilingual-en dataset and convergence configs for llama convergence tests #1080

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

suexu1025
Copy link
Collaborator

@suexu1025 suexu1025 commented Dec 3, 2024

Description

Add c4 configs (c4/en, c4/multilingual-en) for xpk_benchmark_runner to easy configure v5p/trillium model configs to run convergence tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@SujeethJinesh SujeethJinesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a high level, thank you!

@suexu1025 suexu1025 marked this pull request as draft December 16, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants