Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pathways Support to Benchmark Runner #1094

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add Pathways Support to Benchmark Runner #1094

merged 1 commit into from
Jan 10, 2025
+338 −37

Conversation

SujeethJinesh
Copy link
Collaborator

@SujeethJinesh SujeethJinesh commented Dec 10, 2024 •
edited
Loading

Description

Add Pathways support to Benchmark Runner. Makes running benchmarks easier for Pathways scale and long running testing. Also added pathways specific configs for long running tests for now.

Tests

Ran at scale and in long running tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@SujeethJinesh SujeethJinesh force-pushed the sujinesh/llama2_v6e_pw_long_running_test branch 10 times, most recently from 6ed15bc to 7e619b7 Compare December 10, 2024 17:22
@SujeethJinesh SujeethJinesh marked this pull request as ready for review December 11, 2024 17:17
@suexu1025 suexu1025 self-requested a review December 11, 2024 18:31
suexu1025
suexu1025 reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@suexu1025 suexu1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

@SujeethJinesh
Copy link
Collaborator Author

Thank you @suexu1025, resolved your comments

@sadikneipp sadikneipp force-pushed the sujinesh/llama2_v6e_pw_long_running_test branch 2 times, most recently from f202161 to 90107c2 Compare December 16, 2024 21:37
suexu1025
suexu1025 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@suexu1025 suexu1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing all the comments.

@SujeethJinesh SujeethJinesh force-pushed the sujinesh/llama2_v6e_pw_long_running_test branch from 01798e3 to e5114d4 Compare January 9, 2025 21:39
@SujeethJinesh SujeethJinesh force-pushed the sujinesh/llama2_v6e_pw_long_running_test branch from 8b2fc50 to de7e105 Compare January 10, 2025 21:32
@copybara-service copybara-service bot merged commit 3889010 into main Jan 10, 2025
15 checks passed
@copybara-service copybara-service bot deleted the sujinesh/llama2_v6e_pw_long_running_test branch January 10, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobbleturk gobbleturk gobbleturk approved these changes

@suexu1025 suexu1025 suexu1025 approved these changes

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SujeethJinesh @suexu1025 @gobbleturk