Allow debug_dump_gcs to be specified with other XLA_FLAGS #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
debug-dump-gcsdoesn't need to be exclusive with environment-specifiedXLA_FLAGS.Testing / Documentation
Testing details:
xpk workload create ... --debug-dump-gcs gs://foo/bar --env XLA_FLAGS=--xla_dump_to=/foo/bar=>ValueError: Conflict: --xla_dump_to flag defined by both --debug_dump_gcs and XLA_FLAGS in container environment. Please choose one way to define.xpk workload create ... --debug-dump-gcs gs://foo/bar --env XLA_FLAGS=--xla_foo=bar=> workload created with XLA_FLAGS--xla_foo=bar --xla_dump_to=/tmp/xla_dump/xpk workload create ... --debug-dump-gcs gs://foo/bar=> workload created with XLA_FLAGS--xla_dump_to=/tmp/xla_dump/(note the leading space, but XLA has no problem parsing).[ y ] Tests pass
[ y ] Appropriate changes to documentation are included in the PR