chapter1: avoid derogatory term 'mess' #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe the intent of the EBBR specification using more positive terms. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
nullr0ute
reviewed
Apr 16, 2024
| adding a defined standard (UEFI) to the existing firmware projects (U-Boot). | ||
| Or in simpler terms, EBBR is designed to reduce the embedded boot heterogeneity | ||
| by implementing a widely accepted standard (UEFI) in the existing firmware | ||
| projects (U-Boot). |
There was a problem hiding this comment.
You can drop "the" here and just have "in existing firmware projects" or s/projects/project/ because you explicitly mention a single project.
Otherwise LGTM.
robherring
reviewed
Apr 16, 2024
| @@ -55,8 +55,9 @@ The challenge for EBBR is to define a set of boot standards that reduce the | |||
| amount of custom engineering required, make it possible for OS distributions to | |||
| support embedded platforms, while still preserving the firmware stack that | |||
| product vendors are comfortable with. | |||
| Or in simpler terms, EBBR is designed to solve the embedded boot mess by | |||
| adding a defined standard (UEFI) to the existing firmware projects (U-Boot). | |||
| Or in simpler terms, EBBR is designed to reduce the embedded boot heterogeneity | |||
There was a problem hiding this comment.
I would use 'variation' or 'differences' rather than heterogeneity. Might be easier for non-native English speaks?
|
Thanks all for having a look. |
|
Merged with the modifications from @nullr0ute and @robherring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the intent of the EBBR specification using more positive terms.