Require FMP and "on disk" OsIndicationsSupported bits when supported #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an anchor to be able to refer to the "In-band firmware update" section. Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
We require in-band firmware updates in the "Firmware Management Protocol Data Capsule Structure" format. This is a bit misleading as this format described in UEFI § 23.3.2 is only about the capsule body. Refer to the Firmware Management Protocol format instead to avoid the confusion, remove the unnecessary quotation marks and introduce the FMP acronym. Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
Require to set the FMP and "on disk" OsIndicationsSupported bits when in-band firmware update is supported. Signed-off-by: Vincent Stehlé <vincent.stehle@arm.com>
xypron
reviewed
Jan 14, 2025
| @@ -622,8 +622,8 @@ In-band firmware update | |||
|
|
|||
| If firmware update is performed in-band (firmware on the application processor | |||
| updates itself), then the firmware shall implement the `UpdateCapsule()` runtime | |||
| service and accept only authenticated updates in the "Firmware Management | |||
| Protocol Data Capsule Structure" format as described in :UEFI:`23.3`, with | |||
| service and accept only authenticated updates in the Firmware Management | |||
There was a problem hiding this comment.
UpdateCapsule() expects a scatter list. From that scatter list a capsule can be reconstructed as described in "23.3.2 DEFINED FIRMWARE MANAGEMENT PROTOCOL DATA CAPSULE STRUCTURE". The capsule consists of a EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER and a capsule body. The body starts with an EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER.
The term "Firmware Management Protocol Format" would not catch the existence of a scatter list and an EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OsIndicationsSupportedVariable.Therefore, let's require the corresponding
OsIndicationsSupportedbits as well.In this series there is also a commit to add a new section anchor and a commit to clarify our mention of the FMP format, which could probably be merged immediately.