Skip to content

Commit

Permalink
Cleanup data parsing code
Browse files Browse the repository at this point in the history
  • Loading branch information
solidpixel committed Jan 7, 2025
1 parent 81cb3cb commit 0b3795d
Show file tree
Hide file tree
Showing 13 changed files with 753 additions and 464 deletions.
4 changes: 4 additions & 0 deletions .mypy.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[mypy]
exclude = lglpy/timeline/protos/.*\.py
ignore_missing_imports = True
disable_error_code = annotation-unchecked

[mypy-lglpy.timeline.data.raw_trace]
disable_error_code = attr-defined

[mypy-google.*]
ignore_missing_imports = True
14 changes: 7 additions & 7 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ ignore-patterns=^\.#
# manipulated during runtime and thus existing member attributes cannot be
# deduced by static analysis). It supports qualified module names, as well as
# Unix pattern matching.
ignored-modules=cairo
ignored-modules=cairo,protos

# Python code to execute, usually for sys.path manipulation such as
# pygtk.require().
Expand Down Expand Up @@ -293,7 +293,7 @@ ignored-parents=
max-args=5

# Maximum number of attributes for a class (see R0902).
max-attributes=7
max-attributes=12

# Maximum number of boolean expressions in an if statement (see R0916).
max-bool-expr=5
Expand Down Expand Up @@ -342,7 +342,7 @@ indent-after-paren=4
indent-string=' '

# Maximum number of characters on a single line.
max-line-length=100
max-line-length=80

# Maximum number of lines in a module.
max-module-lines=1000
Expand Down Expand Up @@ -436,7 +436,8 @@ disable=raw-checker-failed,
use-implicit-booleaness-not-comparison-to-string,
use-implicit-booleaness-not-comparison-to-zero,
use-symbolic-message-instead,
duplicate-code
duplicate-code,
arguments-differ

# Enable the message, report, category or checker with the given id(s). You can
# either give multiple identifier separated by comma (,) or put this option
Expand All @@ -456,8 +457,7 @@ timeout-methods=requests.api.delete,requests.api.get,requests.api.head,requests.

# List of note tags to take in consideration, separated by a comma.
notes=FIXME,
XXX,
TODO
XXX

# Regular expression of note tags to take in consideration.
notes-rgx=
Expand Down Expand Up @@ -521,7 +521,7 @@ ignore-imports=yes
ignore-signatures=yes

# Minimum lines number of a similarity.
min-similarity-lines=4
min-similarity-lines=10


[SPELLING]
Expand Down
2 changes: 1 addition & 1 deletion lglpy/comms/service_gpu_timeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def handle_render_pass(self, msg: Any) -> None:

# If this is a continuation then merge records
if last_render_pass and (last_render_pass['tid'] == msg['tid']):
# Don't accumulate if tagID is flagged as ambiguous
# Don't accumulate if tag_id is flagged as ambiguous
if last_render_pass['drawCallCount'] != -1:
last_render_pass['drawCallCount'] += msg['drawCallCount']

Expand Down
Loading

0 comments on commit 0b3795d

Please sign in to comment.