ADDED: adviser secret in workflow

ASBTEC · Aug 22, 2024 · d0b559c · d0b559c
1 parent c16f1ef
commit d0b559c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/buildAndSendSignatures.yml b/.github/workflows/buildAndSendSignatures.yml
@@ -44,7 +44,10 @@ env:
   ACTIVITIES_EMAIL: ${{ secrets.ACTIVITIES_EMAIL }}
   ACTIVITIES_POSITION: ${{ secrets.ACTIVITIES_POSITION }}
   ACTIVITIES_LINKEDIN: ${{ secrets.ACTIVITIES_LINKEDIN }}
-
+  ADVISER_NAME: ${{ secrets.ADVISER_NAME }}
+  ADVISER_EMAIL: ${{ secrets.ADVISER_EMAIL }}
+  ADVISER_POSITION: ${{ secrets.ADVISER_POSITION }}
+  ADVISER_LINKEDIN: ${{ secrets.ADVISER_LINKEDIN }}
 jobs:
   build_and_send_signatures:
     runs-on: ubuntu-latest

diff --git a/data/adviser.json b/data/adviser.json
@@ -5,5 +5,3 @@
   "linkedin": "{{LINKEDIN}}"
 }
 
-
-
diff --git a/src/sendEmails.sh b/src/sendEmails.sh
@@ -8,7 +8,7 @@ for signature in $@; do
 
   curl -v --url 'smtps://smtp.gmail.com:465' \
     --ssl-reqd \
-    --mail-from "<${EMAIL_USERNAME}>" \
+    --mail-from "${EMAIL_USERNAME}" \
     --mail-rcpt "${email_value}" \
     --mail-rcpt "${EMAIL_USERNAME}" \
     --user "${EMAIL_USERNAME}:${EMAIL_PASSWORD}" \
@@ -28,6 +28,6 @@ A
     -F "file=@${PROJECT_FOLDER}/out/${signature}.html;type=text/html;encoder=base64" \
     -F '=)' \
     -H "Subject: Actualització de signatures d'email" \
-    -H "From: informatica@asbtec.cat" \
+    -H "From: Informàtica ASBTEC <informatica@asbtec.cat>" \
     -H "To: ${EMAIL_USERNAME} <${EMAIL_USERNAME}>"
 done