Load gem-included types #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note - I also changed the workflow file to test on Ruby >= 2.7 as this is the last version that's not officially EOL. If we need to support older versions (we had 2.4 in the workflow) please let me know. |
added 3 commits
September 7, 2022 09:02
Also dedupe constants when the same constant is included multiple times.
|
This is neat! The RBS gem seems really powerful. Fine with the version bump too - looks like the RBS gem only supports >= 2.6 so we'd need to bump anyway, and going up to after last EOL makes sense. Cheers for your contributions! |
|
Thanks so much! And good to hear the delay was for a good reason (I hope?) Can we get a new version of the gem with the updates please? 🙏 |
|
Sure, will try to cut a release this evening! |
|
@dorner 5.0.0 contains this change! :) |
|
Amazing, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to add RBS to a repo of mine, I ran into an issue where sord was complaining that it couldn't find a constant in one of the included gems - this was despite the fact that the included gem had a
sig/defs.rbsfile as the convention is for generated RBS files.This update pulls in any RBS or RBI signatures to the set of constants that sord knows about.
We can update this in the future to pull in from
sorbet-typedor any other source of RBI/RBS files.For now I made this an automatic change (i.e. not part of a setting), because I'm not really sure why someone would specifically not want to type constants that gems make public. Feedback is welcome!
Related to #147.