Cleaning up .NET 9 locking using source generator. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for your contribution! You've made a really nice library there. 🙂
Unfortunately, I'm not going to merge this, mainly because none of the locks in this project is in the hot path, and I'd like to keep things as simple as possible. To be honest, I'm not even sure using the Lock type is worth releasing a new ZeroLog version.
I'm going to use the global using idea though. I never use global imports so it didn't occur to me they would be perfect in this situation. Would you be interested in contributing this change (a GlobalUsings.cs file in ZeroLog.Impl.Full), even though it wouldn't use your lib?
|
|
||
| namespace ZeroLog.Benchmarks.Tools; | ||
|
|
||
| public class SerilogTestSink : ILogEventSink | ||
| { | ||
| private readonly bool _captureLoggedMessages; | ||
| private readonly object _lock = new(); | ||
| private readonly Lock _lock = new(); |
There was a problem hiding this comment.
Thanks for spotting this!
|
Fixed with 390af98 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.