Add signInFailed check to prevent hanging on hot reload. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Game Center's authentication implementation, the
authenticateHandlerdoes nothing if called again after a user cancels sign in if the app never left the foreground. This can lead to hanging of the app if thesignIncall is awaited.While it can generally fall upon the developer to account for this case in Flutter, a situation occurs when dealing with hot reloads that the developer cannot account for.
This PR adds a check for a previous failed sign in attempt to the
Authclass via Swift's conditional debug compilation to resolve this issue. Release builds are unaffected.