Add playerCentered option to loadLeaderboards.
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to add to changelog when merged. |
|
Hi @theLee3 ! Nice addition! Thanks! |
theLee3
force-pushed
the
player_centered_leaderboards
branch
from
fd6f920 to
d5d3b76
Compare
|
Done. |
Abedalkareem
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving leaderboards via the
loadLeaderboardsmethod, devs may wish to center the results around the player's ranking. To provide this functionality, we can add aplayerCenteredparameter to the method call.GPG provides a method
loadPlayerCenteredScoresso we simply call the correct method based on the value ofplayerCentered.GK does not provide a specific method for this, but we can find the player's rank via
loadEntries(for: currentPlayer)and use the resultinglocalPlayer.rankto calculate theNSRangeto pass to the subsequentloadEntriescall.Both implementations return the top scores if the user does not have an entry on the leaderboard.