Enhance label customization by passing label prop to labelComponent
#959
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to pass the `label` prop directly to the `labelComponent`, enabling external customization of the label rendering. Previously, the `labelComponent` was static and did not accept dynamic input for the label text. With this update, users can now manage the label component and customize its content, style, or behavior outside the `LineChart` component. This flexibility is useful when users need to apply custom rendering logic or styles to the labels based on their application-specific requirements. ### Changes: - Modified `labelComponent` to accept the `label` prop as an argument, allowing it to be passed from the parent. - Updated the rendering logic for both static and animated labels to use the updated `labelComponent` signature.
|
Hi @vinaygupta98, thanks for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to pass the
labelprop directly to thelabelComponent, enabling external customization of the label rendering. Previously, thelabelComponentwas static and did not accept dynamic input for the label text. With this update, users can now manage the label component and customize its content, style, or behavior outside theLineChartcomponent.This flexibility is useful when users need to apply custom rendering logic or styles to the labels based on their application-specific requirements.
Changes:
labelComponentto accept thelabelprop as an argument, allowing it to be passed from the parent.labelComponentsignature.