Skip to content

Commit

Permalink
fix: Fix disappearing security alert response (MetaMask#13027)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR aims to retain `securityAlertResponses` on
`SET_TRANSACTION_OBJECT` action.

## **Related issues**

Fixes: MetaMask/MetaMask-planning#3903

## **Manual testing steps**

1. Open up our [[MetaMask E2E test
dapp](https://metamask.github.io/test-dapp/)](https://metamask.github.io/test-dapp/)
and attempt to prompt a malicious approval for BUSD in our PPOM section.
2. Notice that the malicious warning might popup and stay on screen.

## **Screenshots/Recordings**



https://github.com/user-attachments/assets/60eb5398-c914-4498-8592-4acea5caa163



### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
OGPoyraz authored Jan 16, 2025
1 parent 1f2c1a2 commit 435c9e6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions app/reducers/transaction/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@ const transactionReducer = (state = initialState, action) => {
...getTxData(action.transaction),
},
...txMeta,
// Retain the securityAlertResponses from the old state
securityAlertResponses: state.securityAlertResponses,
};
}
case 'SET_TOKENS_TRANSACTION': {
Expand Down

0 comments on commit 435c9e6

Please sign in to comment.