Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added endpoints for onboarding endpooints #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Ayom04
Copy link
Collaborator

@Ayom04 Ayom04 commented Dec 18, 2023

No description provided.

Copy link
Owner

@Adedoyin-Emmanuel Adedoyin-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, there is a lot going on here. First all form of authentication methods are to be in AuthController methods such as forgot-password, reset-password, verify-email aren't specific to the Buyer or Merchant resource. So please you can add that to the AuthController, Also we don't need to add the payment function in a new folder called service, that's why we've the payment controller, you can create one if it doesn't exist, please all functionality should be in controllers, that way we follow the MVC architecture, if by any means we need to separate a function for reusabliity, you can add that in the /utilis and then import it where necessary. Also concerning using Redis to store cachedOTP or so, during deployment we would've to connect to redis and hence the API dependencies increase, we can just store it in mongoDB as according to the Schema I defined.

@Adedoyin-Emmanuel Adedoyin-Emmanuel added the invalid This doesn't seem right label Dec 19, 2023
@Ayom04
Copy link
Collaborator Author

Ayom04 commented Dec 20, 2023

The reason I created a service folder is just to add any call to the third party api. Anyways I can just put in the controllers. For the authcontollers, we will need to add the user type for each call to the auth route.
Redis, we should remove it then, so we will need to create a collection otp instead of using redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants