Fixes to make the project work with OpenFST 1.8.3 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request AdolfVonKleist#65 from danijel3/master
|
I do have a fork where I merged some of the fixes made in various PRs here. I used it to publish a PyPI package with the prebuilt Python bindings and all necessary OpenFST binaries. I could update that to OpenFST 1.8.3 |
|
The reason I did this is because I used Phonetisaurus extensively with Kaldi and they moved on to 1.8.3. I do recommend the update for standards adherence, but it feels to me that there are probably more changes worthwhile than the couple I made here. Oth, I've been using it in this state for a few hours and so far so good... |
|
Thanks for the fork. If you need help with anything just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the world has moved to version 1.8.3 of OpenFST. I made some cosmetic changes to allow the project to compile correctly.
Note, there are still a ton of warnings during compilation. I haven't made thorough checks to see if everything works (it seems to), but it does compile everything.