Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9481] Removing leftover code #2852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ECP-9481] Removing leftover code #2852

wants to merge 1 commit into from

Conversation

khushboo-singhvi
Copy link
Contributor

Description

While releasing version 9, we decided on the strategy of order cancelation, Now we only depend on the result of the PaymentDetails call, if the response has error, then we cancel the order, otherwise for all other scenarios we wait for OFFER_CLOSE notification. But while doing this, we forgot some code cleanup on the frontend side.
Removing the leftovers

Tested scenarios

Fixes

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner January 15, 2025 15:40
@khushboo-singhvi khushboo-singhvi linked an issue Jan 15, 2025 that may be closed by this pull request
[ECP-9481] Orders cannot be canceled in v9 #2748
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ECP-9481] Orders cannot be canceled in v9
2 participants
@khushboo-singhvi @candemiralp