Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9582] Fix broken Magento compatibility by removing union return type #2859

Merged
merged 2 commits into from
Jan 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@

use Adyen\Payment\Logger\AdyenLogger;
use Exception;
use Magento\Framework\App\ResponseInterface;
use Magento\Framework\Controller\ResultInterface;
use Magento\Framework\Exception\FileSystemException;
use Magento\Framework\Filesystem\DirectoryList;
use Magento\Backend\App\Action\Context;
use Magento\Framework\Controller\ResultFactory;
Expand All @@ -30,7 +28,7 @@ class DownloadApplePayDomainAssociationFile extends Action
const WELL_KNOWN_PATH = '.well-known';

public function __construct(
private readonly Context $context,
Context $context,
private readonly DirectoryList $directoryList,
private readonly File $fileIo,
private readonly AdyenLogger $adyenLogger
Expand All @@ -39,10 +37,9 @@ public function __construct(
}

/**
* @return ResultInterface|ResponseInterface
* @throws FileSystemException
* @return ResultInterface
*/
public function execute(): ResultInterface|ResponseInterface
public function execute(): ResultInterface
{
$redirect = $this->resultFactory->create(ResultFactory::TYPE_REDIRECT);
$redirect->setUrl($this->_redirect->getRefererUrl());
Expand Down
Loading