Chore/bump msrv and deps #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleased Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 37 37
Lines 1405 1405
=======================================
Hits 1095 1095
Misses 310 310 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
trkohler
approved these changes
Aug 26, 2024
trkohler
reviewed
Aug 26, 2024
| @@ -118,6 +118,7 @@ pub struct TtmData { | |||
| /// Set to true if target is a reference used to determine own-ship position or velocity | |||
| pub is_target_reference: bool, | |||
| /// Time of data | |||
| #[cfg_attr(feature = "defmt-03", defmt(Debug2Format))] | |||
There was a problem hiding this comment.
Yes, it is.
We were not testing defmt-03 and NaiveTime needs the Debug2Format as chrono doesn't have defmt impls.
Sadly, Windows build fails so I had to tweak the CI workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @trkohler for the initial PR in #131
I did one small change, to lock the serde_with version to 3.9 but it won't update to 3.10, avoiding any future issues with msrv (hopefully)