New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make method a string instead of arrays #83

Closed

gurisko wants to merge 2 commits into AlbertoFdzM:develop from gurisko:make-methods-string

gurisko commented Apr 24, 2022

The current implementation returns wrong middlewares when path is the same but methods are different. This MR fixes the scenario.

matus-gura-ipf added 2 commits

April 24, 2022 15:21


          Make method a string instead of arrays

00e7487


          Add a test scenario where path is the same but method and middlewares…

4c93218

… are different

gurisko closed this

Author

gurisko commented Apr 24, 2022 •

edited

Loading

I realized that this might not be wanted because of this comment -#81 (comment)

I agree with you, but I'm not sure about the output format (that is something that has bugged me for quite a while). I agree that we need to change the output but it will be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet