Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove podIP patch #752

Closed
wants to merge 1 commit into from

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jan 8, 2025

podIP is only need if user use calico network policy

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 22.34%. Comparing base (4ab7a38) to head (e065445).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
daemon/builder.go 0.00% 17 Missing ⚠️
daemon/daemon.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   23.23%   22.34%   -0.89%     
==========================================
  Files         122      122              
  Lines       16099    16068      -31     
==========================================
- Hits         3740     3591     -149     
- Misses      11950    12085     +135     
+ Partials      409      392      -17     
Flag Coverage Δ
unittests 22.34% <0.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

podIP is only need if user use calico network policy

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@l1b0k l1b0k force-pushed the feat/podip_patch branch from 7ca435f to e065445 Compare January 9, 2025 04:46
@l1b0k l1b0k closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant