fix: ensure sizeX|Y|Z is bigger than zero when picking structure usin…

…g structure command
AllayMC · Dec 25, 2024 · 7fa4797 · 7fa4797
1 parent 16ccb81
commit 7fa4797
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/server/src/main/java/org/allaymc/server/command/defaults/StructureCommand.java b/server/src/main/java/org/allaymc/server/command/defaults/StructureCommand.java
@@ -38,10 +38,18 @@ public void prepareCommandTree(CommandTree tree) {
                     String fileName = context.getResult(1);
                     Vector3f start = ((Vector3f) context.getResult(2)).floor();
                     Vector3f end = ((Vector3f) context.getResult(3)).floor();
+                    var sizeX = (int) (end.x - start.x + 1);
+                    var sizeY = (int) (end.y - start.y + 1);
+                    var sizeZ = (int) (end.z - start.z + 1);
+                    // SizeX|Y|Z should bigger than 0
+                    if (sizeX <= 0 || sizeY <= 0 || sizeZ <= 0) {
+                        context.addError("Invalid size");
+                        return context.fail();
+                    }
                     var structure = Structure.pickStructure(
                             player.getDimension(),
                             (int) start.x, (int) start.y, (int) start.z,
-                            (int) (end.x - start.x), (int) (end.y - start.y), (int) (end.z - start.z),
+                            sizeX, sizeY, sizeZ,
                             true
                     );
                     var filePath = STRUCTURE_DIR.resolve(fileName + STRUCTURE_FILE_EXT);