Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copper blocks behavior #518

Merged
merged 19 commits into from
Dec 22, 2024
Merged

feat: copper blocks behavior #518

merged 19 commits into from
Dec 22, 2024

Conversation

IWareQ
Copy link
Member

@IWareQ IWareQ commented Dec 17, 2024

Affected blocks

Slab, door and trapdoor

To implement it correctly Oxidation these blocks require a basic implementation.
Therefore, this PR can be considered completed as soon as all the tasks are completed.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 34.61538% with 238 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...r/block/component/BlockOxidationComponentImpl.java 2.63% 37 Missing ⚠️
...src/main/java/org/allaymc/api/world/Dimension.java 0.00% 30 Missing ⚠️
...llaymc/server/block/type/BlockTypeInitializer.java 73.91% 30 Missing ⚠️
...erver/item/component/ItemAxeBaseComponentImpl.java 0.00% 29 Missing ⚠️
...server/block/type/BlockTypeDefaultInitializer.java 0.00% 23 Missing ⚠️
...rg/allaymc/api/entity/interfaces/EntityPlayer.java 0.00% 22 Missing ⚠️
...item/component/ItemHoneycombBaseComponentImpl.java 10.00% 18 Missing ⚠️
...c/server/item/component/ItemBaseComponentImpl.java 47.82% 9 Missing and 3 partials ⚠️
...ock/component/door/BlockDoorBaseComponentImpl.java 10.00% 9 Missing ⚠️
...component/button/BlockButtonBaseComponentImpl.java 0.00% 6 Missing ⚠️
... and 14 more
Files with missing lines Coverage Δ Complexity Δ
...llaymc/api/block/component/BlockBaseComponent.java 1.72% <ø> (+0.02%) 1.00 <0.00> (ø)
...ava/org/allaymc/api/block/data/OxidationLevel.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...api/block/property/type/BaseBlockPropertyType.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...in/java/org/allaymc/api/block/type/BlockTypes.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...server/block/component/BlockBaseComponentImpl.java 11.76% <100.00%> (+3.60%) 3.00 <1.00> (+1.00)
...ymc/server/block/impl/BlockCopperBehaviorImpl.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...server/block/impl/BlockCopperBulbBehaviorImpl.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...erver/block/impl/BlockCopperGrateBehaviorImpl.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...rver/block/impl/BlockCopperStairsBehaviorImpl.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../allaymc/server/item/type/ItemTypeInitializer.java 98.84% <100.00%> (+<0.01%) 108.00 <3.00> (+1.00)
... and 24 more

... and 1 file with indirect coverage changes

# Conflicts:
#	.github/workflows/gradle.yml
@smartcmd
Copy link
Member

LGTM!!!!!!!!!

@smartcmd smartcmd merged commit 12ca22f into master Dec 22, 2024
2 checks passed
@IWareQ IWareQ deleted the feat/copper-behavior branch January 14, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants