Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: structure api #523

Merged
merged 15 commits into from
Dec 24, 2024
Merged

feat: structure api #523

merged 15 commits into from
Dec 24, 2024

Conversation

harry-xi
Copy link
Contributor

What it do

  • add structure api
  • add formNbt in BlockStateHelper

notice

  • I didn't test them.
  • As mentioned by todo, I'm not sure the implementation of palce of blockentity is correct

@harry-xi harry-xi marked this pull request as draft December 22, 2024 15:44
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 8.03571% with 206 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...src/main/java/org/allaymc/api/utils/Structure.java 0.00% 141 Missing ⚠️
...laymc/server/command/defaults/GameTestCommand.java 25.58% 32 Missing ⚠️
...g/allaymc/api/block/type/BlockStateSafeGetter.java 5.55% 17 Missing ⚠️
...lock/component/BlockFallableBaseComponentImpl.java 0.00% 4 Missing ⚠️
...component/EntityFallingBlockBaseComponentImpl.java 0.00% 4 Missing ⚠️
.../java/org/allaymc/server/world/AllayDimension.java 0.00% 4 Missing ⚠️
...main/java/org/allaymc/api/utils/AllayNbtUtils.java 62.50% 3 Missing ⚠️
.../server/world/service/AllayBlockUpdateService.java 50.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ Complexity Δ
.../server/world/service/AllayBlockUpdateService.java 15.38% <50.00%> (+2.22%) 3.00 <0.00> (ø)
...main/java/org/allaymc/api/utils/AllayNbtUtils.java 40.81% <62.50%> (-0.10%) 8.00 <1.00> (+1.00) ⬇️
...lock/component/BlockFallableBaseComponentImpl.java 6.25% <0.00%> (+0.53%) 1.00 <0.00> (ø)
...component/EntityFallingBlockBaseComponentImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/allaymc/server/world/AllayDimension.java 30.66% <0.00%> (-0.85%) 7.00 <0.00> (ø)
...g/allaymc/api/block/type/BlockStateSafeGetter.java 47.36% <5.55%> (-19.30%) 2.00 <1.00> (+1.00) ⬇️
...laymc/server/command/defaults/GameTestCommand.java 36.50% <25.58%> (-2.25%) 2.00 <0.00> (ø)
...src/main/java/org/allaymc/api/utils/Structure.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 2 files with indirect coverage changes

@smartcmd smartcmd changed the title Feat: Structure Api feat: structure api Dec 22, 2024
@smartcmd smartcmd requested review from IWareQ and smartcmd December 22, 2024 16:45
@smartcmd smartcmd marked this pull request as ready for review December 24, 2024 14:06
@smartcmd
Copy link
Member

LGTM!!!

@smartcmd smartcmd merged commit f6c73f7 into master Dec 24, 2024
1 check passed
@smartcmd smartcmd deleted the feat/StructureAPI branch December 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants