A few improvements #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added printer_models.py that defines the properties of each supported printer
- Added basic error checking before attempting to print (Open paper compartment and busy) - Unpacking on get_print_status() now works. Tagged unknown values for the time being. - Added two unknown values to InfoEnum
|
You can detect model by sending GetInfo packet. Also checked port serial numbers of my devices so your solution will not work:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @AndBondStyle :)
Here are the changes I made a few months ago.
I'm happy to subdivide them into smaller PRs if you prefer, but I'm unable to do substantial changes due to time constraints on my side.
These were tested on my Niimbot B1 and seem to work well :)
Changes for this PR:
Please let me know if you want me to change something before merging