[WIP] Cython spiceypy prototype #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I may need to transistion to having two pyproject.tomls for spiceypy and cyice which would require some changes to the layout and possibly duplication of get_cspice.py (or make that a third project that all others depend on).
… shared I can focus on vectorized functions
…d examples of list of strings as inputs and outputs
…have to think about how to have good usage of it
…with the cspice src dir so that jobs don't have to download cspice src/compile the cspice lib
…me badness happening with get_spice/setup.py/pyproject.toml
…ure why thats an issue at all though so maybe wheel isn't properly packaging the pyd file
… the python lib path... idk
…name (both file and internal name). Updating to libcspice internally for windows
…all, need to work out a way to have a temp dir that's consistent between running get_spice and defining the cython extension
…y include the so files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype of Cython based interface to CSPICE. Links to the existing CSPICE shared library so is able to work along side the existing spiceypy interface allowing gradual development of features. Current focus will be to provide faster vectorized functions first and then consider what makes sense to cythonize from that point.
This is very much a work in process, as I am still learning cython best practices, and changes to python packaging may be outpacing cython's development and documentation.
Current speedups are modest for vectorized functions, about 1.5-1.7 times faster than pure python versions. This may be due to unavoidable overhead in certain portions such as dealing with strings.
This PR will probably be open for a while until enough of the issues around cross platform compilation, docstrings, and cython usage improvements are made.
suggestions are welcome!