-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call to solver : trial for simplification #2452
base: develop
Are you sure you want to change the base?
Conversation
…I just failed on cucumber step)
b18141c
to
c8d5896
Compare
i'd say building unique_ptr from MPSolverFactory so we don't have to call ORTOOLS_LibererProbleme. |
…s (from week to week)
…lass PROBLEME_SIMPLEXE_NOMME
@@ -212,26 +196,15 @@ static SimplexResult OPT_TryToCallSimplex(const OptimizationOptions& options, | |||
ProblemeAResoudre->ExistenceDUneSolution = Probleme.ExistenceDUneSolution; | |||
if (ProblemeAResoudre->ExistenceDUneSolution != OUI_SPX && PremierPassage) | |||
{ | |||
if (ProblemeAResoudre->ExistenceDUneSolution != SPX_ERREUR_INTERNE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to test ExistenceDUneSolution != SPX_ERREUR_INTERNE
.
But ExistenceDUneSolution == SPX_ERREUR_INTERNE
is impossible : indeed, ExistenceDUneSolution is given by ortools now, which does not know value SPX_ERREUR_INTERNE.
…een MPSolver and PROBLEME_SIMPLEXE_NOMME, possibly useless
Quality Gate passedIssues Measures |
…tus transfers between MPSolver and PROBLEME_SIMPLEXE_NOMME, possibly useless"
This PR follows PR #2450 (that removes direct call to Sirius and forces Sirius behind ortools).
This is a trial for simplifications of code calling the optimization weekly solver call (mainly in opt_appel_solveur_lineaire.cpp)
What was done :
(to keep in mind : deleting a nullptr is harmless)
To be done :
Probleme->ExistenceDUneSolution
and use it in , we could use solver (type MPSolver) returned status.CAUTION :
Remove changes on CI yaml files !